refactor pyclass initialization#5739
Merged
Merged
Conversation
davidhewitt
reviewed
Jan 18, 2026
Closed
Member
Author
|
Maybe a side question: The tuple initializer could be a bit confusing now that we allow arbitrary object (I also always forget which order Subclass and Baseclass should have). Should we consider deprecating that syntax and move people to use |
davidhewitt
approved these changes
Jan 18, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Should we consider deprecating that syntax and move people to use PyClassInitializer directly?
I fully agree that syntax is painful, let's do it in a follow up just because it's a big enough change worth landing, reviewing & documenting in its own PR.
Member
|
(we might also want to consider how to change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the code generation for
#[new]/ pyclass initialization. It uses the same const probe trick we already use elsewhere in the macro machinery to dispatch the initialization based on the return type of the#[new]function. This removes theExistingcase from thePyClassInitializer, making it easier to solve passing arguments to the base__new__in a followup. Additionally it allows to return arbitrary object implementingIntoPyObjectfrom__new__which also takes over theExistingcase.Closes #3291
Closes #4452
Closes #5560